fix: handle deep link too early when onboarding #18363

yqrashawn · 2024-01-03T02:27:09Z

Summary

there's a (get db :onboarding-2/new-account?) in

status-mobile/src/status_im/contexts/profile/login/events.cljs

Line 144 in e7f685f

(rf/defn messenger-started

updated to (get db :onboarding/new-account?)
so that handle deep link won't be triggerd until user press the button an the end of the onboarding flow

status: ready

status-im-auto · 2024-01-03T02:32:15Z

Jenkins Builds

Click to see older builds (47)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`e7f685f`	#1	2024-01-03 02:32:15	~4 min	`tests`	📄`log`
✔️	`e7f685f`	#1	2024-01-03 02:34:14	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`e7f685f`	#1	2024-01-03 02:35:28	~7 min	`android`	🤖`apk` 📲
✔️	`e7f685f`	#1	2024-01-03 02:36:15	~8 min	`ios`	📱`ipa` 📲

✔️	`c133778`	#2	2024-01-03 12:44:36	~4 min	`tests`	📄`log`
✔️	`c133778`	#2	2024-01-03 12:47:43	~7 min	`ios`	📱`ipa` 📲
✔️	`c133778`	#2	2024-01-03 12:47:50	~7 min	`android`	🤖`apk` 📲
✔️	`c133778`	#2	2024-01-03 12:48:09	~8 min	`android-e2e`	🤖`apk` 📲

✔️	`9b842c8`	#3	2024-01-04 01:06:11	~4 min	`tests`	📄`log`
✔️	`9b842c8`	#3	2024-01-04 01:08:09	~6 min	`ios`	📱`ipa` 📲
✔️	`9b842c8`	#3	2024-01-04 01:09:21	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`9b842c8`	#3	2024-01-04 01:09:46	~7 min	`android`	🤖`apk` 📲

✔️	`b771906`	#4	2024-01-05 08:00:56	~5 min	`tests`	📄`log`
✔️	`b771906`	#4	2024-01-05 08:02:00	~6 min	`ios`	📱`ipa` 📲
✔️	`b771906`	#4	2024-01-05 08:04:19	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`b771906`	#4	2024-01-05 08:04:25	~8 min	`android`	🤖`apk` 📲

✔️	`502b6a3`	#5	2024-01-05 12:13:30	~4 min	`tests`	📄`log`
✔️	`502b6a3`	#5	2024-01-05 12:15:25	~6 min	`ios`	📱`ipa` 📲
✔️	`502b6a3`	#5	2024-01-05 12:16:14	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`502b6a3`	#5	2024-01-05 12:16:23	~7 min	`android`	🤖`apk` 📲

✔️	`c8dd6be`	#6	2024-01-08 01:46:42	~5 min	`tests`	📄`log`
✔️	`c8dd6be`	#6	2024-01-08 01:46:47	~5 min	`ios`	📱`ipa` 📲
✔️	`c8dd6be`	#6	2024-01-08 01:47:57	~6 min	`android`	🤖`apk` 📲
✔️	`c8dd6be`	#6	2024-01-08 01:48:34	~7 min	`android-e2e`	🤖`apk` 📲

✔️	`0e2c3ef`	#7	2024-01-09 09:34:56	~5 min	`tests`	📄`log`
✔️	`0e2c3ef`	#7	2024-01-09 09:35:15	~5 min	`ios`	📱`ipa` 📲
✔️	`0e2c3ef`	#7	2024-01-09 09:36:32	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0e2c3ef`	#7	2024-01-09 09:37:18	~7 min	`android`	🤖`apk` 📲

✔️	`9f5f034`	#8	2024-01-09 13:05:48	~5 min	`ios`	📱`ipa` 📲
✔️	`9f5f034`	#8	2024-01-09 13:07:07	~6 min	`android`	🤖`apk` 📲
✔️	`9f5f034`	#9	2024-01-10 01:57:04	~5 min	`tests`	📄`log`

✔️	`f253c02`	#9	2024-01-10 08:54:13	~5 min	`ios`	📱`ipa` 📲
✔️	`f253c02`	#10	2024-01-10 08:54:15	~5 min	`tests`	📄`log`
✔️	`f253c02`	#9	2024-01-10 08:56:06	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`f253c02`	#9	2024-01-10 08:56:14	~7 min	`android`	🤖`apk` 📲

✔️	`0d140be`	#11	2024-01-11 08:01:32	~5 min	`tests`	📄`log`
✔️	`0d140be`	#10	2024-01-11 08:02:09	~6 min	`ios`	📱`ipa` 📲
✔️	`0d140be`	#10	2024-01-11 08:03:37	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0d140be`	#10	2024-01-11 08:03:45	~7 min	`android`	🤖`apk` 📲

❌	`83884da`	#11	2024-01-15 04:50:33	~5 min	`ios`	📄`log`
✔️	`83884da`	#12	2024-01-15 04:50:34	~5 min	`tests`	📄`log`
✔️	`83884da`	#11	2024-01-15 04:51:43	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`83884da`	#11	2024-01-15 04:52:36	~7 min	`android`	🤖`apk` 📲

✔️	`0e7b5c3`	#12	2024-01-15 12:06:53	~5 min	`ios`	📱`ipa` 📲
✔️	`0e7b5c3`	#13	2024-01-15 12:07:37	~6 min	`tests`	📄`log`
✔️	`0e7b5c3`	#12	2024-01-15 12:08:03	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`0e7b5c3`	#12	2024-01-15 12:09:07	~7 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`5adaa52`	#14	2024-01-16 02:02:57	~5 min	`tests`	📄`log`
✔️	`5adaa52`	#13	2024-01-16 02:03:05	~5 min	`ios`	📱`ipa` 📲
✔️	`5adaa52`	#13	2024-01-16 02:05:11	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`5adaa52`	#13	2024-01-16 02:05:12	~7 min	`android`	🤖`apk` 📲

✔️	`14d2da6`	#14	2024-01-16 02:53:25	~5 min	`ios`	📱`ipa` 📲
✔️	`14d2da6`	#15	2024-01-16 02:53:57	~5 min	`tests`	📄`log`
✔️	`14d2da6`	#14	2024-01-16 02:54:38	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`14d2da6`	#14	2024-01-16 02:56:02	~7 min	`android`	🤖`apk` 📲

status-im-auto · 2024-01-03T13:11:54Z

77% of end-end tests have passed

Total executed tests: 48
Failed tests: 6
Expected to fail tests: 5
Passed tests: 37

IDs of failed tests: 702947,702730,702745,702851,703629,702936

IDs of expected to fail tests: 702894,702731,702808,702732,703503

Failed tests (6)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device 1: Wait for text element `EmojisNumber` to be equal to `1` Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-1']/android.widget.TextView` critical/chats/test_1_1_public_chats.py:79: in test_1_1_chat_message_reaction message_sender.emojis_below_message(emoji="love").wait_for_element_text(1, 90) ../views/base_element.py:173: in wait_for_element_text element_text = self.find_element().text.strip() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EmojisNumber by xpath: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-1']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Tap on found: Button Device 1: Find `ProfilePictureElement` by `accessibility id`: `chat-icon` critical/chats/test_1_1_public_chats.py:272: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.profile_1.edit_profile_picture(image_index=2) ../views/profile_view.py:443: in edit_profile_picture self.profile_picture.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: ProfilePictureElement by accessibility id: `chat-icon` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 2: Find Button by accessibility id: tab-contacts
Device 2: Tap on found: Button

activity_center/test_activity_center.py:140: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact was not added to contact list after accepting contact request (as sender)

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629
Device 2: Looking for community: 'open community' Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented `critical/chats/test_public_chat_browsing.py:1136: in test_community_join_when_node_owner_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Joined status is not displayed` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: activity_center/test_activity_center.py:270: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element
2. test_navigation_jump_to, id: 702936
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Wait for element `Button` for max 120s and click when it is available Test setup failed: activity_center/test_activity_center.py:270: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.wait_and_click(120) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (5)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 1: Find ChatElementByText by xpath: //*[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']
Device 1: Find MemberPhoto by xpath: //*[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']

critical/chats/test_public_chat_browsing.py:708: in test_community_contact_block_unblock_offline
    chat_element.member_photo.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: MemberPhoto by xpath: `//*[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

[[Message can be missed after unblock: https://github.com//issues/16873]]

Device sessions

Device 1:

Device 2:

Passed tests (37)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-01-09T13:07:15Z

✔️ status-mobile/prs/android/PR-18363#8 🔹 ~6 min 54 sec 🔹 `9f5f034` 🔹 📦 android package

status-im-auto · 2024-01-09T15:53:40Z

0% of end-end tests have passed

Total executed tests: 3
Failed tests: 3
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 702730,702745,702851

Failed tests (3)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
`Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
`Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

status-im-auto · 2024-01-10T09:35:47Z

67% of end-end tests have passed

Total executed tests: 6
Failed tests: 1
Expected to fail tests: 1
Passed tests: 4

IDs of failed tests: 702947

IDs of expected to fail tests: 703629

Failed tests (1)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device 1: Tap on found: CommunitiesTab
Device 2: Looking for a message by text: something to reply to

activity_center/test_activity_center.py:302: in test_activity_center_reply_read_unread_delete_filter_swipe
    self.channel_2.chat_element_by_text(message_to_reply).wait_for_visibility_of_element(120)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'something to reply to')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Tap on found: Button
Device 2: Looking for community: 'open community'

critical/chats/test_public_chat_browsing.py:1175: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 open community is not listed inside Pending communities tab
E    Joined status is not displayed
E    open community is not listed inside Joined communities tab

[[Can't join a community if admin goes offline, https://github.com//issues/17678]]

Device sessions

Device 1:

Device 2:

Passed tests (4)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-01-11T09:44:39Z

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Expected to fail tests: 0
Passed tests: 1

Passed tests (1)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-01-11T13:23:56Z

Hi @yqrashawn! Thanks for the PR!
I see a cool result on iOS part. But here is a result from Android:

ISSUE 1 : [Android] User is not redirected to the Status app after tap on community universal link

Steps:

Paste a community universal link to browser/messanger (https://status.app/c/G0UAAMTyNsn2QZDEG0EXftOl8pOEfwEBOOSA_YTfIk85xmADDgINGmxpUHAXzK36bN0fK42Xf4YD2yjPk1z2pbFwFw==#zQ3shVH64F3hhMpkfZnjCq4aHePrvLfbN1dBh1qjCe1VNyfUJ)

Actual result: user see a community page opened in a mobile browser

link_issue.mp4

It repoduces on PR builds. Nightly doesn't have this issue.

Expected result: user should be able to be redirected to a Status App

actual_result.mp4

yqrashawn · 2024-01-11T14:14:15Z

Hi @mariia-skrypnyk, can you try paste the link into chrome browser see if it opens up status app?
This happens before, not working in telegram and works in chrome. Just want to know if it's the same situation.

#18177

mariia-skrypnyk · 2024-01-11T14:41:07Z

Hi @mariia-skrypnyk, can you try paste the link into chrome browser see if it opens up status app? This happens before, not working in telegram and works in chrome. Just want to know if it's the same situation.

Thanks for you comment @yqrashawn! I double-checked it and it has the same result as from the Telegram.

mariia-skrypnyk · 2024-01-12T11:14:09Z

Hi @yqrashawn! I see you've maid a new builds!
Can I check them for the fix? Thanks!

yqrashawn · 2024-01-15T04:47:22Z

Hi @mariia-skrypnyk
these changes are just rebase to the latest dev branch
universal link trigger app open is out of scope of this issue
it breaks randomly, so I created a new issue to record these breaks
issue is at #18490
and current app behavior is tracked at this notion doc https://www.notion.so/Universal-link-outside-app-won-t-trigger-app-open-feef7657dcc64017ba9c75e176533597?pvs=4

mariia-skrypnyk · 2024-01-15T11:10:32Z

Tested in this PR:

user can be redirected to the onboarding using this universal links format https://status.app/ by opening from an external messenger/browser and user is successfully created
user is successfully created during all onboarding steps and appropriate screen opens after (different types of links: user profile, community, and community channel links)
for scenarios when: the app is not installed; the app is installed, no profile; the app is installed, the user is logged out; the app is installed, the user is logged in
opening in Status chats/browser
on iOS and Android devices (Android contains issue that blocks a lot of links test but they are not in the scope of this PR)
invalid links
links posted in different types of Status chats

Great job @yqrashawn, PR can be merged!

yqrashawn self-assigned this Jan 3, 2024

yqrashawn requested a review from flexsurfer January 3, 2024 03:05

yqrashawn added the request-manual-qa label Jan 3, 2024

ibrkhalil approved these changes Jan 3, 2024

View reviewed changes

yqrashawn force-pushed the fix/handle-deep-link-too-early branch from e7f685f to c133778 Compare January 3, 2024 12:39

yqrashawn force-pushed the fix/handle-deep-link-too-early branch from c133778 to 9b842c8 Compare January 4, 2024 01:01

flexsurfer approved these changes Jan 4, 2024

View reviewed changes

yqrashawn force-pushed the fix/handle-deep-link-too-early branch 4 times, most recently from c8dd6be to 0e2c3ef Compare January 9, 2024 09:29

mariia-skrypnyk self-assigned this Jan 9, 2024

yqrashawn force-pushed the fix/handle-deep-link-too-early branch from 0e2c3ef to 9f5f034 Compare January 9, 2024 13:00

pavloburykh force-pushed the fix/handle-deep-link-too-early branch from 9f5f034 to f253c02 Compare January 10, 2024 08:48

yqrashawn force-pushed the fix/handle-deep-link-too-early branch from f253c02 to 0d140be Compare January 11, 2024 07:55

mariia-skrypnyk added the Tested - Issues label Jan 11, 2024

yqrashawn mentioned this pull request Jan 15, 2024

Universal link outside status won't trigger status app open #18490

Open

80 tasks

yqrashawn force-pushed the fix/handle-deep-link-too-early branch from 0d140be to 83884da Compare January 15, 2024 04:44

mariia-skrypnyk added Tested - OK and removed Tested - Issues labels Jan 15, 2024

yqrashawn force-pushed the fix/handle-deep-link-too-early branch 2 times, most recently from 0e7b5c3 to 5adaa52 Compare January 16, 2024 01:57

fix: handle deep link too early when onboarding

14d2da6

yqrashawn force-pushed the fix/handle-deep-link-too-early branch from 5adaa52 to 14d2da6 Compare January 16, 2024 02:47

yqrashawn merged commit a2bf23c into develop Jan 16, 2024
6 checks passed

yqrashawn deleted the fix/handle-deep-link-too-early branch January 16, 2024 08:08

fix: handle deep link too early when onboarding #18363

fix: handle deep link too early when onboarding #18363

Conversation

yqrashawn commented Jan 3, 2024

Summary

status-im-auto commented Jan 3, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Jan 3, 2024

77% of end-end tests have passed

Failed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Expected to fail tests (5)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Passed tests (37)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

status-im-auto commented Jan 9, 2024

✔️ status-mobile/prs/android/PR-18363#8 🔹 ~6 min 54 sec 🔹 9f5f034 🔹 📦 android package

status-im-auto commented Jan 9, 2024

0% of end-end tests have passed

Failed tests (3)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Jan 10, 2024

67% of end-end tests have passed

Failed tests (1)

Class TestActivityMultipleDevicePR:

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMergedTwo:

Passed tests (4)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Jan 11, 2024

100% of end-end tests have passed

Passed tests (1)

Class TestActivityMultipleDevicePR:

mariia-skrypnyk commented Jan 11, 2024 • edited Loading

yqrashawn commented Jan 11, 2024 • edited Loading

mariia-skrypnyk commented Jan 11, 2024

mariia-skrypnyk commented Jan 12, 2024

yqrashawn commented Jan 15, 2024 • edited Loading

mariia-skrypnyk commented Jan 15, 2024 • edited Loading

status-im-auto commented Jan 3, 2024 •

edited

Loading

✔️ status-mobile/prs/android/PR-18363#8 🔹 ~6 min 54 sec 🔹 `9f5f034` 🔹 📦 android package

mariia-skrypnyk commented Jan 11, 2024 •

edited

Loading

yqrashawn commented Jan 11, 2024 •

edited

Loading

yqrashawn commented Jan 15, 2024 •

edited

Loading

mariia-skrypnyk commented Jan 15, 2024 •

edited

Loading